Merge branch 'oban/more-improvements' into 'develop'

Oban: more improvements

See merge request pleroma/pleroma!4187

changelog.d/oban-cancel-badreq.change

@@ -0,0 +1 @@
+Publisher jobs will not retry if the error received is a 400

changelog.d/oban-cancel-poll-result.change

@@ -0,0 +1 @@
+PollWorker jobs will not retry if the activity no longer exists.

changelog.d/oban-cancel-receiverworker.change

@@ -0,0 +1 @@
+Improved detecting unrecoverable errors for incoming federation jobs

lib/pleroma/web/activity_pub/publisher.ex

@@ -123,6 +123,7 @@ def publish_one(%{inbox: inbox, json: json, actor: %User{} = actor, id: id} = pa
         Logger.error("Publisher failed to inbox #{inbox} with status #{code}")
 
         case response do
+          %{status: 400} -> {:cancel, :bad_request}
           %{status: 403} -> {:cancel, :forbidden}
           %{status: 404} -> {:cancel, :not_found}
           %{status: 410} -> {:cancel, :not_found}

lib/pleroma/web/activity_pub/side_effects.ex

@@ -453,7 +453,7 @@ defp handle_update_object(
        ) do
     orig_object_ap_id = updated_object["id"]
     orig_object = Object.get_by_ap_id(orig_object_ap_id)
-    orig_object_data = orig_object.data
+    orig_object_data = Map.get(orig_object, :data)
 
     updated_object =
       if meta[:local] do

lib/pleroma/workers/background_worker.ex

@@ -40,5 +40,5 @@ def perform(%Job{args: %{"op" => "verify_fields_links", "user_id" => user_id}})
   end
 
   @impl Oban.Worker
-  def timeout(_job), do: :timer.seconds(5)
+  def timeout(_job), do: :timer.seconds(15)
 end

lib/pleroma/workers/poll_worker.ex

@@ -17,6 +17,9 @@ def perform(%Job{args: %{"op" => "poll_end", "activity_id" => activity_id}}) do
     with %Activity{} = activity <- find_poll_activity(activity_id),
          {:ok, notifications} <- Notification.create_poll_notifications(activity) do
       Notification.stream(notifications)
+    else
+      {:error, :poll_activity_not_found} = e -> {:cancel, e}
+      e -> {:error, e}
     end
   end
 

lib/pleroma/workers/receiver_worker.ex

@@ -47,11 +47,13 @@ defp process_errors(errors) do
     case errors do
       {:error, :origin_containment_failed} -> {:cancel, :origin_containment_failed}
       {:error, :already_present} -> {:cancel, :already_present}
-      {:error, {:validate_object, reason}} -> {:cancel, reason}
-      {:error, {:error, {:validate, reason}}} -> {:cancel, reason}
-      {:error, {:reject, reason}} -> {:cancel, reason}
+      {:error, {:validate_object, _} = reason} -> {:cancel, reason}
+      {:error, {:error, {:validate, {:error, _changeset} = reason}}} -> {:cancel, reason}
+      {:error, {:reject, _} = reason} -> {:cancel, reason}
       {:signature, false} -> {:cancel, :invalid_signature}
-      {:error, {:error, reason = "Object has been deleted"}} -> {:cancel, reason}
+      {:error, "Object has been deleted"} = reason -> {:cancel, reason}
+      {:error, {:side_effects, {:error, :no_object_actor}} = reason} -> {:cancel, reason}
+      {:error, :not_found} = reason -> {:cancel, reason}
       {:error, _} = e -> e
       e -> {:error, e}
     end

lib/pleroma/workers/remote_fetcher_worker.ex

@@ -31,5 +31,5 @@ def perform(%Job{args: %{"op" => "fetch_remote", "id" => id} = args}) do
   end
 
   @impl Oban.Worker
-  def timeout(_job), do: :timer.seconds(10)
+  def timeout(_job), do: :timer.seconds(15)
 end

lib/pleroma/workers/user_refresh_worker.ex

@@ -13,5 +13,5 @@ def perform(%Job{args: %{"ap_id" => ap_id}}) do
   end
 
   @impl Oban.Worker
-  def timeout(_job), do: :timer.seconds(5)
+  def timeout(_job), do: :timer.seconds(15)
 end

test/pleroma/workers/receiver_worker_test.exs

@@ -16,7 +16,7 @@ test "it does not retry MRF reject" do
 
     with_mock Pleroma.Web.ActivityPub.Transmogrifier,
       handle_incoming: fn _ -> {:reject, "MRF"} end do
-      assert {:cancel, "MRF"} =
+      assert {:cancel, {:reject, "MRF"}} =
                ReceiverWorker.perform(%Oban.Job{
                  args: %{"op" => "incoming_ap_doc", "params" => params}
                })