bigbuffet/pleroma
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add tests for fetchRelationships() action

Browse source
This commit is contained in:
Justin 2022-06-23 15:17:36 -04:00
parent 2cc38554fa
commit ba595259c1
2 changed files with 100 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

94
app/soapbox/actions/__tests__/accounts.test.ts
View file

@ -14,6 +14,7 @@ import {
fetchAccountByUsername,
fetchFollowers,
fetchFollowing,
fetchRelationships,
followAccount,
muteAccount,
removeFromFollowers,
@ -1308,3 +1309,96 @@ describe('expandFollowing()', () => {
});
});
});
describe('fetchRelationships()', () => {
const id = '1';
describe('when logged out', () => {
beforeEach(() => {
const state = rootReducer(undefined, {}).set('me', null);
store = mockStore(state);
});
it('should do nothing', async() => {
await store.dispatch(fetchRelationships([id]));
const actions = store.getActions();
expect(actions).toEqual([]);
});
});
describe('when logged in', () => {
beforeEach(() => {
const state = rootReducer(undefined, {})
.set('me', '123');
store = mockStore(state);
});
describe('without newAccountIds', () => {
beforeEach(() => {
const state = rootReducer(undefined, {})
.set('relationships', ImmutableMap({ [id]: {} }))
.set('me', '123');
store = mockStore(state);
});
it('should do nothing', async() => {
await store.dispatch(fetchRelationships([id]));
const actions = store.getActions();
expect(actions).toEqual([]);
});
});
describe('with a successful API request', () => {
beforeEach(() => {
const state = rootReducer(undefined, {})
.set('relationships', ImmutableMap({}))
.set('me', '123');
store = mockStore(state);
__stub((mock) => {
mock
.onGet(`/api/v1/accounts/relationships?${[id].map(id => `id[]=${id}`).join('&')}`)
.reply(200, []);
});
});
it('should dispatch the correct actions', async() => {
const expectedActions = [
{ type: 'RELATIONSHIPS_FETCH_REQUEST', ids: [id], skipLoading: true },
{
type: 'RELATIONSHIPS_FETCH_SUCCESS',
relationships: [],
skipLoading: true,
},
];
await store.dispatch(fetchRelationships([id]));
const actions = store.getActions();
expect(actions).toEqual(expectedActions);
});
});
describe('with an unsuccessful API request', () => {
beforeEach(() => {
__stub((mock) => {
mock
.onGet(`/api/v1/accounts/relationships?${[id].map(id => `id[]=${id}`).join('&')}`)
.networkError();
});
});
it('should dispatch the correct actions', async() => {
const expectedActions = [
{ type: 'RELATIONSHIPS_FETCH_REQUEST', ids: [id], skipLoading: true },
{ type: 'RELATIONSHIPS_FETCH_FAIL', skipLoading: true, error: new Error('Network Error') },
];
await store.dispatch(fetchRelationships([id]));
const actions = store.getActions();
expect(actions).toEqual(expectedActions);
});
});
});
});

13
app/soapbox/actions/accounts.ts
View file

@ -656,22 +656,21 @@ const expandFollowingFail = (id: string, error: AxiosError) => ({
const fetchRelationships = (accountIds: string[]) =>
(dispatch: AppDispatch, getState: () => RootState) => {
if (!isLoggedIn(getState)) return;
if (!isLoggedIn(getState)) return null;
const loadedRelationships = getState().relationships;
const newAccountIds = accountIds.filter(id => loadedRelationships.get(id, null) === null);
if (newAccountIds.length === 0) {
return;
return null;
}
dispatch(fetchRelationshipsRequest(newAccountIds));
api(getState).get(`/api/v1/accounts/relationships?${newAccountIds.map(id => `id[]=${id}`).join('&')}`).then(response => {
dispatch(fetchRelationshipsSuccess(response.data));
}).catch(error => {
dispatch(fetchRelationshipsFail(error));
});
return api(getState)
.get(`/api/v1/accounts/relationships?${newAccountIds.map(id => `id[]=${id}`).join('&')}`)
.then(response => dispatch(fetchRelationshipsSuccess(response.data)))
.catch(error => dispatch(fetchRelationshipsFail(error)));
};
const fetchRelationshipsRequest = (ids: string[]) => ({