From 50f65bc7c97db6e127553c1811edaa66d7c9296e Mon Sep 17 00:00:00 2001
From: Alex Gleason <alex@alexgleason.me>
Date: Thu, 23 Mar 2023 14:52:38 -0500
Subject: [PATCH] useCreateEntity: pass an EntityRequest, refactor

---
 .../entity-store/hooks/useCreateEntity.ts     | 50 ++++++-------------
 .../entity-store/hooks/useEntityActions.ts    | 13 ++---
 2 files changed, 23 insertions(+), 40 deletions(-)

diff --git a/app/soapbox/entity-store/hooks/useCreateEntity.ts b/app/soapbox/entity-store/hooks/useCreateEntity.ts
index 373434e73c..432bea8fa5 100644
--- a/app/soapbox/entity-store/hooks/useCreateEntity.ts
+++ b/app/soapbox/entity-store/hooks/useCreateEntity.ts
@@ -1,52 +1,45 @@
 import { z } from 'zod';
 
-import { useAppDispatch } from 'soapbox/hooks';
+import { useApi, useAppDispatch } from 'soapbox/hooks';
 
 import { importEntities } from '../actions';
 
-import { parseEntitiesPath } from './utils';
+import { parseEntitiesPath, toAxiosRequest } from './utils';
 
 import type { Entity } from '../types';
-import type { EntitySchema, ExpandedEntitiesPath } from './types';
-
-type CreateFn<Params, Result> = (params: Params) => Promise<Result> | Result;
+import type { EntityRequest, EntitySchema, ExpandedEntitiesPath } from './types';
 
 interface UseCreateEntityOpts<TEntity extends Entity = Entity> {
   schema?: EntitySchema<TEntity>
 }
 
-type CreateEntityResult<TEntity extends Entity = Entity, Result = unknown, Error = unknown> =
-  {
-    success: true
-    result: Result
-    entity: TEntity
-  } | {
-    success: false
-    error: Error
-  }
-
 interface EntityCallbacks<TEntity extends Entity = Entity, Error = unknown> {
   onSuccess?(entity: TEntity): void
   onError?(error: Error): void
 }
 
-function useCreateEntity<TEntity extends Entity = Entity, Params = any, Result = unknown>(
+function useCreateEntity<TEntity extends Entity = Entity, Data = any>(
   expandedPath: ExpandedEntitiesPath,
-  createFn: CreateFn<Params, Result>,
+  request: EntityRequest,
   opts: UseCreateEntityOpts<TEntity> = {},
 ) {
-  const { entityType, listKey } = parseEntitiesPath(expandedPath);
-
+  const api = useApi();
   const dispatch = useAppDispatch();
 
+  const { entityType, listKey } = parseEntitiesPath(expandedPath);
+
   return async function createEntity(
-    params: Params,
+    data: Data,
     callbacks: EntityCallbacks = {},
-  ): Promise<CreateEntityResult<TEntity>> {
+  ): Promise<void> {
     try {
-      const result = await createFn(params);
+      const result = await api.request({
+        ...toAxiosRequest(request),
+        data,
+      });
+
       const schema = opts.schema || z.custom<TEntity>();
-      const entity = schema.parse(result);
+      const entity = schema.parse(result.data);
 
       // TODO: optimistic updating
       dispatch(importEntities([entity], entityType, listKey));
@@ -54,21 +47,10 @@ function useCreateEntity<TEntity extends Entity = Entity, Params = any, Result =
       if (callbacks.onSuccess) {
         callbacks.onSuccess(entity);
       }
-
-      return {
-        success: true,
-        result,
-        entity,
-      };
     } catch (error) {
       if (callbacks.onError) {
         callbacks.onError(error);
       }
-
-      return {
-        success: false,
-        error,
-      };
     }
   };
 }
diff --git a/app/soapbox/entity-store/hooks/useEntityActions.ts b/app/soapbox/entity-store/hooks/useEntityActions.ts
index 9312aef67d..509e3c95ea 100644
--- a/app/soapbox/entity-store/hooks/useEntityActions.ts
+++ b/app/soapbox/entity-store/hooks/useEntityActions.ts
@@ -18,7 +18,7 @@ interface EntityActionEndpoints {
   delete?: string
 }
 
-function useEntityActions<TEntity extends Entity = Entity, Params = any>(
+function useEntityActions<TEntity extends Entity = Entity, Data = any>(
   expandedPath: ExpandedEntitiesPath,
   endpoints: EntityActionEndpoints,
   opts: UseEntityActionsOpts<TEntity> = {},
@@ -34,11 +34,12 @@ function useEntityActions<TEntity extends Entity = Entity, Params = any>(
       .finally(() => setIsLoading(false));
   });
 
-  const createEntity = useCreateEntity(path, (params: Params) => {
-    if (!endpoints.post) return Promise.reject(endpoints);
-    return api.post(endpoints.post, params)
-      .finally(() => setIsLoading(false));
-  }, opts);
+  const create = useCreateEntity<TEntity, Data>(path, { method: 'post', url: endpoints.post }, opts);
+
+  const createEntity: typeof create = async (...args) => {
+    await create(...args);
+    setIsLoading(false);
+  };
 
   return {
     createEntity,