bigbuffet/bigbuffet-rw
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge branch 'media-modal-fixes' into 'develop'

Browse source 
Media modal fixes

Closes #1431 and #1432

See merge request soapbox-pub/soapbox!2536
This commit is contained in:
Alex Gleason 2023-06-01 01:26:39 +00:00
commit d50a62791a
2 changed files with 47 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

85
app/soapbox/features/ui/components/modals/media-modal.tsx
View file

@ -70,7 +70,7 @@ const MediaModal: React.FC<IMediaModal> = (props) => {
const [next, setNext] = useState<string>();
const [index, setIndex] = useState<number | null>(null);
const [navigationHidden, setNavigationHidden] = useState(false);
const [isFullScreen, setIsFullScreen] = useState(false);
const [isFullScreen, setIsFullScreen] = useState(!status);
const hasMultipleImages = media.size > 1;
@ -219,12 +219,14 @@ const MediaModal: React.FC<IMediaModal> = (props) => {
};
}, [index]);
if (!actualStatus && isLoaded) {
return (
<MissingIndicator />
);
} else if (!actualStatus) {
return <PlaceholderStatus />;
if (status) {
if (!actualStatus && isLoaded) {
return (
<MissingIndicator />
);
} else if (!actualStatus) {
return <PlaceholderStatus />;
}
}
return (
@ -255,21 +257,22 @@ const MediaModal: React.FC<IMediaModal> = (props) => {
<HStack alignItems='center' space={2}>
<IconButton
src={require('@tabler/icons/download.svg')}
// title={intl.formatMessage(isFullScreen ? messages.minimize : messages.expand)}
theme='dark'
className='!p-1.5 hover:scale-105 hover:bg-gray-900'
iconClassName='h-5 w-5'
onClick={handleDownload}
/>
<IconButton
src={isFullScreen ? require('@tabler/icons/arrows-minimize.svg') : require('@tabler/icons/arrows-maximize.svg')}
title={intl.formatMessage(isFullScreen ? messages.minimize : messages.expand)}
theme='dark'
className='!p-1.5 hover:scale-105 hover:bg-gray-900'
iconClassName='h-5 w-5'
onClick={() => setIsFullScreen(!isFullScreen)}
/>
{status && (
<IconButton
src={isFullScreen ? require('@tabler/icons/arrows-minimize.svg') : require('@tabler/icons/arrows-maximize.svg')}
title={intl.formatMessage(isFullScreen ? messages.minimize : messages.expand)}
theme='dark'
className='!p-1.5 hover:scale-105 hover:bg-gray-900'
iconClassName='h-5 w-5'
onClick={() => setIsFullScreen(!isFullScreen)}
/>
)}
</HStack>
</HStack>
@ -311,31 +314,35 @@ const MediaModal: React.FC<IMediaModal> = (props) => {
)}
</div>
<HStack justifyContent='center' className='flex-[0_0_60px]'>
<StatusActionBar
status={actualStatus}
space='md'
statusActionButtonTheme='inverse'
/>
</HStack>
{actualStatus && (
<HStack justifyContent='center' className='flex-[0_0_60px]'>
<StatusActionBar
status={actualStatus}
space='md'
statusActionButtonTheme='inverse'
/>
</HStack>
)}
</Stack>
<div
className={
clsx('-right-96 hidden bg-white transition-all xl:fixed xl:inset-y-0 xl:right-0 xl:flex xl:w-96 xl:flex-col', {
'xl:!-right-96': isFullScreen,
})
}
>
<Thread
status={actualStatus}
withMedia={false}
useWindowScroll={false}
itemClassName='px-4'
next={next}
handleLoadMore={handleLoadMore}
/>
</div>
{actualStatus && (
<div
className={
clsx('-right-96 hidden bg-white transition-all xl:fixed xl:inset-y-0 xl:right-0 xl:flex xl:w-96 xl:flex-col', {
'xl:!-right-96': isFullScreen,
})
}
>
<Thread
status={actualStatus}
withMedia={false}
useWindowScroll={false}
itemClassName='px-4'
next={next}
handleLoadMore={handleLoadMore}
/>
</div>
)}
</div>
</div>
);

2
app/styles/components/detailed-status.scss
View file

@ -1,5 +1,5 @@
.thread {
@apply bg-white dark:bg-primary-900 sm:rounded-xl;
@apply bg-white dark:bg-primary-900;
&__status {
@apply relative pb-4;