bigbuffet/bigbuffet-rw
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge branch 'compose-emoji-typing' into 'develop'

Browse source 
AutosuggestTextarea: shouldComponentUpdate fixes

See merge request soapbox-pub/soapbox-fe!278
This commit is contained in:
Alex Gleason 2020-09-29 05:07:34 +00:00
commit ca0d39ef88
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/soapbox/components/autosuggest_textarea.js
View file

@ -160,9 +160,12 @@ export default class AutosuggestTextarea extends ImmutablePureComponent {
}
shouldComponentUpdate(nextProps, nextState) {
// Skip updating when lastToken changes so the cursor doesn't jump around
// due to re-rendering unnecessarily
if (this.state.lastToken !== nextState.lastToken) {
// Skip updating when only the lastToken changes so the
// cursor doesn't jump around due to re-rendering unnecessarily
const lastTokenUpdated = this.state.lastToken !== nextState.lastToken;
const valueUpdated = this.props.value !== nextProps.value;
if (lastTokenUpdated && !valueUpdated) {
return false;
} else {
return super.shouldComponentUpdate(nextProps, nextState);