bigbuffet/bigbuffet-rw
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

AutosuggestInput/AutosuggestTextarea: short-circuit RTL check earlier

Browse source
This commit is contained in:
Alex Gleason 2022-12-23 16:26:07 -06:00
parent 8fde7f267d
commit c788916644
No known key found for this signature in database
GPG key ID: 7211D1F99744FBB7
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/soapbox/components/autosuggest-input.tsx
View file

@ -269,7 +269,7 @@ export default class AutosuggestInput extends ImmutablePureComponent<IAutosugges
const visible = !suggestionsHidden && (!suggestions.isEmpty() || (menu && value)); const visible = !suggestionsHidden && (!suggestions.isEmpty() || (menu && value));
// TODO: convert to functional component and use `useLocale()` hook instead of checking placeholder text. // TODO: convert to functional component and use `useLocale()` hook instead of checking placeholder text.
if (isRtl(value) || (placeholder && isRtl(placeholder) && !value)) { if (isRtl(value) || (!value && placeholder && isRtl(placeholder))) {
style.direction = 'rtl'; style.direction = 'rtl';
} }

2
app/soapbox/components/autosuggest-textarea.tsx
View file

@ -230,7 +230,7 @@ class AutosuggestTextarea extends ImmutablePureComponent<IAutosuggesteTextarea>
const style = { direction: 'ltr', minRows: 10 }; const style = { direction: 'ltr', minRows: 10 };
// TODO: convert to functional component and use `useLocale()` hook instead of checking placeholder text. // TODO: convert to functional component and use `useLocale()` hook instead of checking placeholder text.
if (isRtl(value) || (placeholder && isRtl(placeholder) && !value)) { if (isRtl(value) || (!value && placeholder && isRtl(placeholder))) {
style.direction = 'rtl'; style.direction = 'rtl';
} }