Merge branch 'auth-fix' into 'develop'

Don't call verify_credentials twice when an account fails

See merge request soapbox-pub/soapbox!2553

CHANGELOG.md

@@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Compatibility: fix version parsing for Friendica.
 - UI: fixed various overflow issues related to long usernames.
 - UI: fixed display of Markdown code blocks in the reply indicator.
+- Auth: fixed too many API requests when the server has an error.
 
 ## [3.2.0] - 2023-02-15
 

app/soapbox/actions/auth.ts

@@ -178,8 +178,7 @@ export const rememberAuthAccount = (accountUrl: string) =>
 
 export const loadCredentials = (token: string, accountUrl: string) =>
   (dispatch: AppDispatch) => dispatch(rememberAuthAccount(accountUrl))
-    .then(() => dispatch(verifyCredentials(token, accountUrl)))
-    .catch(() => dispatch(verifyCredentials(token, accountUrl)));
+    .finally(() => dispatch(verifyCredentials(token, accountUrl)));
 
 export const logIn = (username: string, password: string) =>
   (dispatch: AppDispatch) => dispatch(getAuthApp()).then(() => {