bigbuffet/bigbuffet-rw
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge branch 'unmount-noscroll' into 'develop'

Browse source 
Don't hijack scrollbar when status is unmounted, fixes #404

Closes #404

See merge request soapbox-pub/soapbox-fe!221
This commit is contained in:
Alex Gleason 2020-09-09 19:48:55 +00:00
commit 69cd155c21
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
app/soapbox/components/status.js
View file

@ -151,14 +151,16 @@ class Status extends ImmutablePureComponent {
} }
componentWillUnmount() { componentWillUnmount() {
if (this.node && this.props.getScrollPosition) { // FIXME: Run this code only when a status is being deleted.
const position = this.props.getScrollPosition(); //
if (position !== null && this.node.offsetTop < position.top) { // if (this.node && this.props.getScrollPosition) {
requestAnimationFrame(() => { // const position = this.props.getScrollPosition();
this.props.updateScrollBottom(position.height - position.top); // if (position !== null && this.node.offsetTop < position.top) {
}); // requestAnimationFrame(() => {
} // this.props.updateScrollBottom(position.height - position.top);
} // });
// }
// }
} }
handleToggleMediaVisibility = () => { handleToggleMediaVisibility = () => {