From ae5e4c05f66acf9659a4263476863c917d4f7c74 Mon Sep 17 00:00:00 2001 From: Alex Gleason Date: Wed, 30 Nov 2022 21:45:31 -0600 Subject: [PATCH 1/2] ColumnHeader: remove `transparent` prop, pass className from Column instead --- app/soapbox/components/ui/column/column.tsx | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/app/soapbox/components/ui/column/column.tsx b/app/soapbox/components/ui/column/column.tsx index 62aede9b2..f25990c2f 100644 --- a/app/soapbox/components/ui/column/column.tsx +++ b/app/soapbox/components/ui/column/column.tsx @@ -7,10 +7,10 @@ import { useSoapboxConfig } from 'soapbox/hooks'; import { Card, CardBody, CardHeader, CardTitle } from '../card/card'; -type IColumnHeader = Pick; +type IColumnHeader = Pick; /** Contains the column title with optional back button. */ -const ColumnHeader: React.FC = ({ label, backHref, transparent }) => { +const ColumnHeader: React.FC = ({ label, backHref, className }) => { const history = useHistory(); const handleBackClick = () => { @@ -27,10 +27,7 @@ const ColumnHeader: React.FC = ({ label, backHref, transparent }) }; return ( - + ); @@ -72,7 +69,11 @@ const Column: React.FC = React.forwardRef((props, ref: React.ForwardedR {withHeader && ( - + )} From 69d64c11b438fa1c2d391c8cacb246fa7eb1a0ee Mon Sep 17 00:00:00 2001 From: Alex Gleason Date: Wed, 30 Nov 2022 21:45:49 -0600 Subject: [PATCH 2/2] Fix spacing of ColumnHeader on Local/Federated timelines --- app/soapbox/features/community-timeline/index.tsx | 2 +- app/soapbox/features/public-timeline/index.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/soapbox/features/community-timeline/index.tsx b/app/soapbox/features/community-timeline/index.tsx index a49093dc6..a5c2a17fa 100644 --- a/app/soapbox/features/community-timeline/index.tsx +++ b/app/soapbox/features/community-timeline/index.tsx @@ -40,7 +40,7 @@ const CommunityTimeline = () => { }, [onlyMedia]); return ( - + { }, [onlyMedia]); return ( - + {showExplanationBox &&