bigbuffet/bigbuffet-rw
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Suggestions: fix optimistic dismissal

Browse source
This commit is contained in:
Alex Gleason 2021-10-02 15:18:27 -05:00
parent fcd9e47a99
commit 1be73d13a1
No known key found for this signature in database
GPG key ID: 7211D1F99744FBB7
2 changed files with 29 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
app/soapbox/reducers/__tests__/suggestions-test.js
View file

@ -1,5 +1,6 @@
import reducer from '../suggestions';
import { Map as ImmutableMap, List as ImmutableList } from 'immutable';
import { Map as ImmutableMap, List as ImmutableList, fromJS } from 'immutable';
import { SUGGESTIONS_DISMISS } from 'soapbox/actions/suggestions';
describe('suggestions reducer', () => {
it('should return the initial state', () => {
@ -8,4 +9,29 @@ describe('suggestions reducer', () => {
isLoading: false,
}));
});
describe('SUGGESTIONS_DISMISS', () => {
it('should remove the account', () => {
const action = { type: SUGGESTIONS_DISMISS, id: '123' };
const state = fromJS({
items: [
{ account: '123', source: 'past_interactions' },
{ account: '456', source: 'past_interactions' },
{ account: '789', source: 'past_interactions' },
],
isLoading: false,
});
const expected = fromJS({
items: [
{ account: '456', source: 'past_interactions' },
{ account: '789', source: 'past_interactions' },
],
isLoading: false,
});
expect(reducer(state, action)).toEqual(expected);
});
});
});

4
app/soapbox/reducers/suggestions.js
View file

@ -39,11 +39,11 @@ const importSuggestions = (state, suggestions) => {
};
const dismissAccount = (state, accountId) => {
return state.update('items', list => list.filterNot(x => x.account === accountId));
return state.update('items', items => items.filterNot(item => item.get('account') === accountId));
};
const dismissAccounts = (state, accountIds) => {
return state.update('items', list => list.filterNot(x => accountIds.includes(x.account)));
return state.update('items', items => items.filterNot(item => accountIds.includes(item.get('account'))));
};
export default function suggestionsReducer(state = initialState, action) {